FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Small readability updates by jpatrao · Pull Request #184 · InnerSourceCommons/InnerSourcePatterns · GitHub

/ InnerSourcePatterns Public

Small readability updates - #184

Merged
lenucksi merged 2 commits into
InnerSourceCommons:masterfrom
jpatrao:patch-3
Jul 30, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Small readability updates#184
lenucksi merged 2 commits into
InnerSourceCommons:masterfrom
jpatrao:patch-3

Conversation

jpatrao commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

Small readability updates. Because a certain paragraph within the solution section was not clear to me ... and I guess to others too, I did rework it. Closer attention needs to be paid here because I did not intend to change the meaning of what was written.

Small readability updates
cff66d7 
Small readability updates.
spier reviewed Jul 22, 2020
View reviewed changes

spier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The wording/grammar changes look good to me.

I added a question in the one paragraph where you tried to simplify the text. There I am not sure how it was meant by the original author.

Comment thread start-as-experiment.md
lenucksi approved these changes Jul 22, 2020
View reviewed changes

lenucksi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey @jpatrao, thanks for improving the phrasing and readability here! 🎉
I would merge but I'm agree with @spier on his comment which keeps me from insta-merging this.
Please take a look at the inline comment.

Comment thread start-as-experiment.md

jpatrao commented Jul 29, 2020

Copy link
Copy Markdown
Contributor Author

@lenucksi @spier Please take a look at the revised edits from me.

spier commented Jul 29, 2020

Copy link
Copy Markdown
Member

@jpatrao I don't see any new edits or commits. Are you referring to your proposal in here?
https://github.com/InnerSourceCommons/InnerSourcePatterns/pull/184/files#r459058825

jpatrao commented Jul 29, 2020

Copy link
Copy Markdown
Contributor Author

@jpatrao I don't see any new edits or commits. Are you referring to your proposal in here?
https://github.com/InnerSourceCommons/InnerSourcePatterns/pull/184/files#r459058825

@spier Yes.

lenucksi approved these changes Jul 30, 2020
View reviewed changes

lenucksi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks again for the changes, this looks good to me right now :)

lenucksi merged commit c241f79 into InnerSourceCommons:master Jul 30, 2020

spier commented Jul 30, 2020

Copy link
Copy Markdown
Member

🎉

lenucksi added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

spier spier left review comments
lenucksi lenucksi approved these changes
cewilliams Awaiting requested review from cewilliams
gruetter Awaiting requested review from gruetter
NewMexicoKid Awaiting requested review from NewMexicoKid
nyeates Awaiting requested review from nyeates

Assignees

No one assigned

Labels

📖 Type - Content Work Working on contents is the main focus of this issue / PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL