Switch to CommonJS export in types - #16
Open
karlhorky wants to merge 1 commit into
Open
karlhorky wants to merge 1 commit into
karlhorky wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
andrewbranch
suggested changes
Jul 29, 2024
andrewbranch
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
I don’t think this change is valid. You can’t have an export * and an export =.
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Ah alright, thanks for the response! Maybe this would require a more complex type, since after reviewing the lib/index.js it appears that both rehypeTocModule.default and rehypeTocModule actually exist: "use strict";
var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
}) : (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
o[k2] = m[k];
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
};
Object.defineProperty(exports, "__esModule", { value: true });
exports.toc = void 0;
const rehype_toc_1 = require("./rehype-toc");
Object.defineProperty(exports, "toc", { enumerable: true, get: function () { return rehype_toc_1.toc; } });
__exportStar(require("./types"), exports);
// Export `toc` as the default export
exports.default = rehype_toc_1.toc;
// CommonJS default export hack
/* eslint-env commonjs */
if (typeof module === "object" && typeof module.exports === "object") {
module.exports = Object.assign(module.exports.default, module.exports);
}
//# sourceMappingURL=index.js.map |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for @jsdevtools/rehype-toc!
To avoid having to access .default in moduleResolution: 'Node16' or newer:
TypeScript Playground
Error message:
'moduleExpected' is declared but its value is never read.(6133) Type 'typeof import("file:///node_modules/@jsdevtools/rehype-toc/lib/index")' is not assignable to type '(...args: any[]) => any'. Type 'typeof import("file:///node_modules/@jsdevtools/rehype-toc/lib/index")' provides no match for the signature '(...args: any[]): any'.(2322)Interestingly I don't see a problem on Are the types wrong?:
cc @andrewbranch