FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add support for postgres drop function statement by rrrship · Pull Request #1557 · JSQLParser/JSqlParser · GitHub

/ JSqlParser Public

add support for postgres drop function statement - #1557

Merged
wumpz merged 2 commits into
JSQLParser:masterfrom
rrrship:master
Jul 6, 2022
ConversationCommits (2)ChecksFiles changed
Merged

add support for postgres drop function statement#1557
wumpz merged 2 commits into
JSQLParser:masterfrom
rrrship:master

Conversation

rrrship commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Adds a support for PostgreSQL DROP FUNCTION statement: PostgreSQL DROP FUNCTION documentation

Also added a new map to Drop class to store parameters by type. Not sure about other drop types, but drop function actually has a more richer syntax with additional parameters which we could support in the future. Storing them in a map could possibly hold off bloating the class.

manticore-projects commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Greetings.

Thank you very much for your contribution. It looks great, kudos!
@wumpz: Its high quality content and I would like to recommend speedy adoption.

rrrship commented Jun 27, 2022

Copy link
Copy Markdown
Contributor Author

Since I'm new to open source development and contribution, I wanted to ask when and how often are the pull requests merged to master.

manticore-projects commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

Since I'm new to open source development and contribution, I wanted to ask when and how often are the pull requests merged to master.

Honestly, I do not know either and I am thinking about establishing a "Development Branch", which would merge any pending PRs under a rolling release model.

wumpz merged commit 964fa49 into JSQLParser:master Jul 6, 2022

wumpz commented Jul 6, 2022

Copy link
Copy Markdown
Member

@rrrship sorry about the delay.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL