FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add support comment in `create view` for MySQL and MariaDb by jxnu-liguobin · Pull Request #1913 · JSQLParser/JSqlParser · GitHub

/ JSqlParser Public

feat: Add support comment in create view for MySQL and MariaDb - #1913

Merged
manticore-projects merged 6 commits into
JSQLParser:masterfrom
jxnu-liguobin:view-comment
Dec 14, 2023
ConversationCommits (6)ChecksFiles changed
Merged

feat: Add support comment in create view for MySQL and MariaDb#1913
manticore-projects merged 6 commits into
JSQLParser:masterfrom
jxnu-liguobin:view-comment

Conversation

jxnu-liguobin commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

No description provided.

jxnu-liguobin changed the title feat: Add support comment in create view for mysql feat: Add support comment in create view for MySQL and mariaDb Dec 14, 2023
jxnu-liguobin changed the title feat: Add support comment in create view for MySQL and mariaDb feat: Add support comment in create view for MySQL and MariaDb Dec 14, 2023
manticore-projects requested changes Dec 14, 2023
View reviewed changes

manticore-projects left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for your contribution.
It looks great in general but I wonder if we can reuse the existing Production ColumnDefinition and use an ExpressionList for the collection.

Comment thread src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Outdated
}
}

ColumnDefinition ColumnDefinitionItem():

manticore-projects Dec 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There should be a similar Production already, please try to re-use it.

Comment thread src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Outdated
}
}

List<ColumnDefinition> ColumnDefinitionItemList():

manticore-projects Dec 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please try to use an ExpressionList<Column> here.

manticore-projects merged commit 4d47e0a into JSQLParser:master Dec 14, 2023

manticore-projects commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Thank you for your very good contribution, we do appreciate!

manticore-projects commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Please would you still like to fix the Grammar regarding

Warning: Choice conflict in [...] construct at line 1774, column 5.
         Expansion nested within construct and expansion following construct
         have common prefixes, one of which is: "COMMENT"
         Consider using a lookahead of 2 or more for nested expansion.

jxnu-liguobin commented Dec 14, 2023

Copy link
Copy Markdown
Contributor Author

COMMENT

ok

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

manticore-projects manticore-projects requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL