feat: Support FOR SHARE - #1922
Merged
manticore-projects merged 5 commits intoDec 16, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
manticore-projects
requested changes
Dec 16, 2023
manticore-projects
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I have concerns on this implementation, when building this statement with java code.
Sorry, something went wrong.
Comment thread
src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
| [ LOOKAHEAD(<K_FETCH>) fetch = Fetch() { plainSelect.setFetch(fetch); } ] | ||
| [ LOOKAHEAD(<K_WITH> <K_ISOLATION>) withIsolation = WithIsolation() { plainSelect.setIsolation(withIsolation); } ] | ||
| [ LOOKAHEAD(2) <K_FOR> <K_UPDATE> { plainSelect.setForUpdate(true); } | ||
| [ LOOKAHEAD(2) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks much better, well done!
Sorry, something went wrong.
| } | ||
|
|
||
| @Test | ||
| public void testIssue1878ViaJava() throws JSQLParserException { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good!
Sorry, something went wrong.
manticore-projects
self-requested a review
December 16, 2023 10:48
manticore-projects
approved these changes
Dec 16, 2023
Copy link
Copy Markdown
Contributor
|
Thank you a lot for providing this implementation! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1878
MySQL: FOR {UPDATE | SHARE}
PostgreSQL: FOR { UPDATE | NO KEY UPDATE | SHARE | KEY SHARE }