FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: support mysql with rollup by jxnu-liguobin · Pull Request #1923 · JSQLParser/JSqlParser · GitHub

feat: support mysql with rollup - #1923

Merged
manticore-projects merged 3 commits into
JSQLParser:masterfrom
jxnu-liguobin:resolve-issue-1907
Dec 19, 2023
Merged

feat: support mysql with rollup#1923
manticore-projects merged 3 commits into
JSQLParser:masterfrom
jxnu-liguobin:resolve-issue-1907

Conversation

Copy link
Copy Markdown
Contributor

try to closed #1907

this.mysqlWithRollup = mysqlWithRollup;
}

public GroupByElement withMysqlWithRollup(boolean mysqlWithRollup) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I know, that previously those "withMethods" have been implemented, but nobody ever gave me a reason why the "setMethod" should not return the object directly.

Feel free to avoid that redundant "withMethod" and return the object when calling the "set" method.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To my knowledge, in functional programming, it is generally referred to as with. The true meaning is to create a new object and return it without modifying the object itself, but here, with modifies the object, so set and with are indeed duplicates at this point.

Copy link
Copy Markdown
Contributor

I have fixed the Test related issues not linked to this PR directly. Please re-sync, sorry for the extra step.

Copy link
Copy Markdown
Contributor Author

I have fixed the Test related issues not linked to this PR directly. Please re-sync, sorry for the extra step.

Thank you, I have revised it.

manticore-projects left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good.

manticore-projects merged commit 77f6fb8 into JSQLParser:master Dec 19, 2023

Copy link
Copy Markdown
Contributor

Thank you for working on this!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WITH ROLLUP clause

2 participants


Back | FazBrowse Home | New Git URL