| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| this.mysqlWithRollup = mysqlWithRollup; | ||
| } | ||
|
|
||
| public GroupByElement withMysqlWithRollup(boolean mysqlWithRollup) { |
There was a problem hiding this comment.
I know, that previously those "withMethods" have been implemented, but nobody ever gave me a reason why the "setMethod" should not return the object directly.
Feel free to avoid that redundant "withMethod" and return the object when calling the "set" method.
Sorry, something went wrong.
There was a problem hiding this comment.
To my knowledge, in functional programming, it is generally referred to as with. The true meaning is to create a new object and return it without modifying the object itself, but here, with modifies the object, so set and with are indeed duplicates at this point.
Sorry, something went wrong.
|
I have fixed the Test related issues not linked to this PR directly. Please re-sync, sorry for the extra step. |
Sorry, something went wrong.
Thank you, I have revised it. |
Sorry, something went wrong.
There was a problem hiding this comment.
looks good.
Sorry, something went wrong.
|
Thank you for working on this! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
try to closed #1907