FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: tables not find in parentheses join sql. by Hanchers · Pull Request #1956 · JSQLParser/JSqlParser · GitHub

/ JSqlParser Public

fix: tables not find in parentheses join sql. - #1956

Merged
manticore-projects merged 5 commits into
JSQLParser:masterfrom
Hanchers:issue-1955
Feb 7, 2024
ConversationCommits (5)ChecksFiles changed
Merged

fix: tables not find in parentheses join sql.#1956
manticore-projects merged 5 commits into
JSQLParser:masterfrom
Hanchers:issue-1955

Conversation

Hanchers commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

to fix bug #1955

manticore-projects commented Feb 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your contribution and the fix, please see my comments.
The Spotless Formatter also raised concerns.

Hanchers commented Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again

manticore-projects commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again

I still see the "star" imports, please import Classes explicitly instead.

Hanchers commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again

I still see the "star" imports, please import Classes explicitly instead.

sorry, my idea have a auto import config that couse the "star" imports.
this time i fix this question and please review again.
thanks

manticore-projects requested changes Feb 7, 2024
View reviewed changes
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Outdated
Comment thread src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java Outdated
Comment thread src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java Outdated

manticore-projects commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Thank you for the corrections and your contribution. I am going to merge it.

Hanchers commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for the corrections and your contribution. I am going to merge it.

thanks， my pleasure

manticore-projects merged commit 182f484 into JSQLParser:master Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

manticore-projects manticore-projects approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL