FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: issue1875 by SheldonKubor · Pull Request #1957 · JSQLParser/JSqlParser · GitHub

fix: issue1875 - #1957

Merged
manticore-projects merged 2 commits into
JSQLParser:masterfrom
SheldonKubor:feat-issue-1875
Feb 7, 2024
Merged

fix: issue1875#1957
manticore-projects merged 2 commits into
JSQLParser:masterfrom
SheldonKubor:feat-issue-1875

Conversation

Copy link
Copy Markdown
Contributor

Temporarily solve the issue 1875 #1875 .
Refactoring may take more time. And in my opinion, we should discuss how to refactor.

Copy link
Copy Markdown
Contributor

we should discuss how to refactor.

The DDL statements are a big mess, best illustrated here: https://manticore-projects.com/JSQLParser/syntax_snapshot.html#createtable
The syntax diagram does not even fit on the page.

I would like to advise for a refactoring which splits this one into many smaller, re-usable productions where grammar and code can be shared between CREATE and ALTER as much as possible -- based on the SQL:2016 standard.

A good blueprint maybe here: https://manticore-projects.com/SQL2016Parser/syntax.html#table-definition and https://manticore-projects.com/SQL2016Parser/syntax.html#alter-table-statement

Copy link
Copy Markdown
Contributor

Clean and neat as always, thanks a lot for working on this. Cheers!

manticore-projects merged commit 98aa90c into JSQLParser:master Feb 7, 2024
SheldonKubor deleted the feat-issue-1875 branch February 7, 2024 08:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL