fix: Fixes parsing failing for ALTER MODIFY queries not containing datatype - #1961
Merged
manticore-projects merged 2 commits intoFeb 8, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thank you for your contribution! Please fix the Spotless Formatter exception and then I can merge this. |
Sorry, something went wrong.
manticore-projects
requested changes
Feb 8, 2024
Comment thread
src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@manticore-projects thanks for reviewing. Addressed the issues. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Thanks! It looks good and I am going to merge. |
Sorry, something went wrong.
manticore-projects
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I took a pass at fixing #1727
This PR makes colDataType an optional value, so we can parse queries like
ALTER TABLE table MODIFY col1 NULL