chore adding extra details to unit test scenarios - #2051
Merged
manticore-projects merged 2 commits intoJul 31, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/test/java/net/sf/jsqlparser/statement/delete/DeleteTest.java
Outdated
manticore-projects
requested changes
Jul 31, 2024
manticore-projects
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please refactor the duplicate/redundant parser calls.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thank you for this contribution. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a future change in mind to do with CTEs. When I make the PR for this change I would like the unit tests changes (if any) to be simple and easy to understand. So, before I start to look at my CTE related change, I've added extra details to the UpdateTest, InsertTest, DeleteTest and SelectTest unit test scenarios.
There are zero functionality changes made here, only unit tests updates, I've been very careful not to change any SQL statements being tested.