FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Skyline syntax (preferring clause) by ssteinhauser · Pull Request #2078 · JSQLParser/JSqlParser · GitHub

/ JSqlParser Public

Skyline syntax (preferring clause) - #2078

Merged
manticore-projects merged 6 commits into
JSQLParser:masterfrom
ssteinhauser:feature/skyline-syntax
Sep 17, 2024
ConversationCommits (6)ChecksFiles changed
Merged

Skyline syntax (preferring clause)#2078
manticore-projects merged 6 commits into
JSQLParser:masterfrom
ssteinhauser:feature/skyline-syntax

Conversation

ssteinhauser commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

This PR implements the skyline syntax (preferring clause) of Exasol which is available for SELECT, UPDATE and DELETE statements. For more details see https://docs.exasol.com/db/latest/advanced_analytics/skyline.htm

ssteinhauser marked this pull request as draft September 16, 2024 07:37
ssteinhauser marked this pull request as ready for review September 16, 2024 08:03

manticore-projects commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Thank you much for your contribution and effort!
Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.

manticore-projects requested changes Sep 17, 2024
View reviewed changes

manticore-projects left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please no wild card imports (as requested by @wumpz).
Rest looks great as usual and I would merge immediately when this will have been cleaned up. Thanks!

Comment thread src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/statement/select/PlainSelect.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/validation/validator/ExpressionValidator.java Outdated
Comment thread src/main/java/net/sf/jsqlparser/util/validation/validator/ExpressionValidator.java Outdated

manticore-projects commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Please check for ALL wild card imports (in case I have missed to mark one), thanks!

ssteinhauser commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

Thank you much for your contribution and effort! Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.

You're welcome and thank you also for your support!

Currently, I don't have a complete overview of Exasol syntax which is not supported by JSqlParser, but my next implementation will be the support of the IMPORT (with subimport as part of select) and EXPORT statements of Exasol.
So a 5.1 release might make sense then.

ssteinhauser commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

Please check for ALL wild card imports (in case I have missed to mark one), thanks!

Will do and sorry - my IDE did that automatically.

manticore-projects merged commit d1373c5 into JSQLParser:master Sep 17, 2024

manticore-projects commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Please check for ALL wild card imports (in case I have missed to mark one), thanks!

Will do and sorry - my IDE did that automatically.

there should be a configuration for this (even project specific).

ssteinhauser deleted the feature/skyline-syntax branch September 17, 2024 09:32

manticore-projects commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Thank you much for your contribution and effort! Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.

You're welcome and thank you also for your support!

Currently, I don't have a complete overview of Exasol syntax which is not supported by JSqlParser, but my next implementation will be the support of the IMPORT (with subimport as part of select) and EXPORT statements of Exasol. So a 5.1 release might make sense then.

Ok, so I would like to suggest we will wait with 5.1 for this specific stuff and then will aim for a release when this would be ready.
Cheers!

This was referenced Jan 5, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

manticore-projects manticore-projects approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL