FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

migration of fastify@4 to @5 by bourgeoa · Pull Request #125 · JavaScriptSolidServer/JavaScriptSolidServer · GitHub

  1. JavaScriptSolidServer
  2. JavaScriptSolidServer

Repository navigation

migration of fastify@4 to @5 - #125

Open
bourgeoa wants to merge 1 commit into
JavaScriptSolidServer:gh-pagesfrom
bourgeoa:fastify-v5
ConversationCommits (1)ChecksFiles changed
Open

migration of fastify@4 to @5#125
bourgeoa wants to merge 1 commit into
JavaScriptSolidServer:gh-pagesfrom
bourgeoa:fastify-v5

Conversation

bourgeoa commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown

#124 Fastify v4 to v5 migration

Summary

  • Fastify v5 migration complete: deps bumped, Node engine set to 20+, redirect signature fixed, HEAD ordering corrected.
  • URL/host handling normalized via getRequestHost() and applied across handlers, auth, notifications, ActivityPub, and server headers to fix port/subdomain consistency.
  • WebSocket notifications fixed for v5: correct handler signature, async WebID resolution, Updates‑Via includes port; all notifications tests pass.
  • Live reload: watcher now closes on shutdown; tests use OS temp dir for Windows; live‑reload test now exits cleanly.
  • README Node.js requirement updated to 20+.
  • Full test run: npm test passing (224/224).

Notes

  • Live reload test previously hung because the filesystem watcher stayed open; now closed via Fastify onClose.
  • README prereqs updated to Node.js 20+ to align with engines.

melvincarvalho mentioned this pull request Feb 23, 2026
Open
melvincarvalho self-requested a review as a code owner May 27, 2026 05:34

CLAassistant commented Jun 14, 2026

Copy link
Copy Markdown


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

melvincarvalho Awaiting requested review from melvincarvalho melvincarvalho is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL