FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

--conneg ACL by bourgeoa · Pull Request #333 · JavaScriptSolidServer/JavaScriptSolidServer · GitHub

Repository navigation

--conneg ACL - #333

Open
bourgeoa wants to merge 23 commits into
JavaScriptSolidServer:gh-pagesfrom
bourgeoa:gh-pages
Open

bourgeoa wants to merge 23 commits into
JavaScriptSolidServer:gh-pagesfrom
bourgeoa:gh-pages

Conversation

bourgeoa commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

This fixes --conneg for .acl resources stored as JSON-LD.

This should close #327 --conneg render ACL without content

Root cause was in jsonLdToQuads:

  • ACL documents are written as @context + @graph, but the conversion only collected top-level nodes with @id, so the ACL graph was skipped and Turtle output contained only prefixes.
  • CURIE object IDs such as acl:Read and foaf:Agent were not expanded through the JSON-LD context before URI resolution.

Changes in this PR:

  • collect nodes from @graph in jsonLdToQuads
  • expand CURIE-based @id values before resolveUri

added regression coverage in conneg.test.js:

  • write an explicit full .acl JSON-LD document
  • use the real webId returned by createTestPod()
  • authenticate .acl GETs to match the current JSS rule that ACL access requires acl:Control

This now covers the actual failing case: an explicit ACL JSON-LD document with @graph and CURIE-based values rendered through --conneg as Turtle.

bourgeoa added 20 commits April 29, 2026 11:25
- verify_credentials, follow, notifications, home timeline
- statuses: create, edit, source, history, permalink, favourite
- profile: update_credentials with avatar/header upload
- account lookup, search (v1 + v2 with URL resolution), preferences, relationships
- lists and account lists endpoints (empty, prevents client null crash)
- WebSocket streaming endpoint
- OAuth client persistence across restarts
- host-meta discovery
- Remote account resolution via WebFinger + actor cache
- Outbound Follow delivery: HTTP-signed Follow activity to remote inbox
- Storage layout: per-pod .ap/activitypub.db, server-wide .idp/ap/keys+oauth
- OAuth discovery: /.well-known/oauth-authorization-server
- 34 tests passing
melvincarvalho self-requested a review as a code owner May 27, 2026 05:34

Copy link
Copy Markdown


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conneg .acl rendered without content

2 participants


Back | FazBrowse Home | New Git URL