FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implement INSERT and UPDATE parsing by gpittarelli · Pull Request #10 · JavaScriptor/js-sql-parser · GitHub

Implement INSERT and UPDATE parsing - #10

Open
gpittarelli wants to merge 3 commits into
JavaScriptor:masterfrom
gpittarelli:master
Open

Implement INSERT and UPDATE parsing#10
gpittarelli wants to merge 3 commits into
JavaScriptor:masterfrom
gpittarelli:master

Conversation

gpittarelli commented Apr 10, 2018
edited
Loading

Copy link
Copy Markdown

Implements parsing for INSERT and UPDATE queries, per the MySQL 5.7 grammar. Includes pretty printing + test cases.

(Note: for my own purposes, I've published this branch under @gpittarelli/js-sql-parser)

albin3 commented Apr 11, 2018

Copy link
Copy Markdown
Member

Great, i'm a little busy these days, i will review it later.

albin3 commented Jul 15, 2018

Copy link
Copy Markdown
Member

hi, @gpittarelli .

I reviewed the insert part in this pr and there are something need to change / some questions need to confirm:

  1. following https://dev.mysql.com/doc/refman/5.7/en/insert.html , simple_table_factor grammar may be should be replaced by identifier.
  2. more test cases are needed for for the new code.
  3. suggestion: format the code more similar with document in https://dev.mysql.com/doc/refman/5.7/en/insert.html , such as there are three insert grammars in document, we also write it into three lines. So, it's more readable.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL