Broken build due to import - #22
Merged
albin3 merged 1 commit intoJul 25, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Please excuse the typo which caused the horribly long initial title. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@michaelmior sorry for the typo. new version: v1.1.0 has released to fix this issue. It's probably caused by my typo when editing "travel". When I type "ti" in vscode, and it just add import { timingSafeEqual } from "crypto" in the head of the file. Will add test case to check these case before release. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
No problem. Thanks for the fix! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently an unused import statement which ends up appearing in the built parser. With the latest release of this module, this breaks my code since import statements aren't directly supported. In general, this could be handled by preprocessing with something like Babel, but in this case, the import wasn't actually used so I just removed it.
Would be great if another release could be made after this is merged :)`