FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added a few more tests to improve code coverage by lightswitch05 · Pull Request #163 · JoshData/python-email-validator · GitHub

/ python-email-validator Public

Added a few more tests to improve code coverage - #163

Merged
JoshData merged 1 commit into
JoshData:mainfrom
lightswitch05:add-more-tests
Oct 27, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Added a few more tests to improve code coverage#163
JoshData merged 1 commit into
JoshData:mainfrom
lightswitch05:add-more-tests

Conversation

lightswitch05 commented Oct 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

I see I was woefully late providing updates to #155 and the issue was already addressed. But it seems test were not added. I thought I could maybe help out with a few at least. While I was adding tests, I improve test coverage in a few other spots as well. I think it only bumps the over-all coverage by 1% - but maybe its useful.

lightswitch05 commented Oct 25, 2025
View reviewed changes
Comment thread tests/mocked-dns-answers.json
"class": "IN"
},
"answer": []
"answer": ["127.0.0.1"]

lightswitch05 Oct 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Being a non-global address results in the same behavior - but covers more code.

JoshData commented Oct 27, 2025

Copy link
Copy Markdown
Owner

Thanks!!

Just one check is failing now in tests:

tests/test_main.py:85: error: Function is missing a type annotation for one or more arguments [no-untyped-def]

lightswitch05 commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

@JoshData sorry about that - its fixed up now. Since it is a test for an invalid type... I used Any. I'm not sure what your thoughts are on the Any type, I see its used in another test. I can change it if you like.

JoshData commented Oct 27, 2025

Copy link
Copy Markdown
Owner

Since this is just in tests that seems totally fine. Thanks!

JoshData merged commit 52b24c6 into JoshData:main Oct 27, 2025
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL