| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #294 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 2027 2045 +18
=========================================
+ Hits 2027 2045 +18 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
Benchmark Results
|
Sorry, something went wrong.
|
I'm not sure I understand what this PR does. If we pre-specify the type of decompression when we do the coloring, doesn't it make the uplo argument useless? And if not, which uplo setting takes precedence, the one in the result or the one in the argument? |
Sorry, something went wrong.
|
Yes, I should make the uplo argument useless (if we specialize it in the result for :L or :U). The one in the result always takes precedence. |
Sorry, something went wrong.
|
I took a second look and the semantics of this are a bit confusing to me. From what I understand:
|
Sorry, something went wrong.
You are right!
Yes, because the option decompression_uplo is not yet exposed for the users and I don't want to do breaking changes. |
Sorry, something went wrong.
| nzA = nonzeros(A) | ||
| check_compatible_pattern(A, ag, uplo) | ||
| if uplo == :F | ||
| if result.decompression_uplo == uplo |
There was a problem hiding this comment.
Why is this case not considered for the TreeSetColoringResult below?
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Add an argument decompression_uplo for StarSetColoringResult and TreeSetColoringResult such that we can specialize the decompression for bicoloring.
We can always use decompression_uplo = :L for the bicoloring.
For the bicoloring, decompress! only use the specialized version for SparseMatrixCSC since #288.
Everything is internal so it is not breaking.
Replace #289.
I will wait a review of Guillaume before that I merge this PR and future modifications.