fix: pin fury<2 and fastcore<2 to unbreak dipy and fastai tests (#1556) · Kaggle/docker-python@78aaa43 · GitHub

Kaggle / docker-python Public

• Notifications You must be signed in to change notification settings
• Fork 1k
• Star 2.7k

• Code
• Issues 25
• Pull requests 8
• Actions
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 78aaa43

Browse filesBrowse the repository at this point in the historyBrowse files

KeijiBranshi

and

claude

authored

fix: pin fury<2 and fastcore<2 to unbreak dipy and fastai tests (#1556)

BUG=[b/545164527](http://b/545164527) The scheduled build re-resolves kaggle_requirements.txt against live PyPI, so a rebuild of an unchanged commit picks up new upstream releases. Two major versions landed since the last green build and broke all four test stages: - fury 2.0.0 swapped the VTK backend for pygfx/wgpu, dropping the APIs dipy.viz needs. test_dipy fails at import. dipy/dipy#3978 - fastcore v2 removed L.starmap, called by fastai's set_hypers. test_fastai.test_tabular fails with AttributeError. fastai/fastai#4154 Both consumers declare unbounded requirements (fury>=0.12.0, fastcore>=1.14.6), so nothing stopped the resolver from crossing the major version boundary. Neither upstream has a released fix, so pin both with TODOs. fastcore is capped directly rather than via a direct dep: five packages pull it uncapped, and execnb>=2.2.5 alone forces v2, so pinning nbdev does not help. Even nbdev<3 still resolves fastcore 2.2.12. Verified by building the CPU image both ways. Before: fury 2.0.0 / fastcore 2.2.12, both tests fail with the CI tracebacks. After: fury 0.12.0 / fastcore 1.14.5 / nbdev 3.1.0, both tests pass and nbdev, execnb, ghapi and learntools still import. See b/545164527#comment3 for successful build Co-authored-by: Claude <noreply@anthropic.com>

1 parent fc61d5c commit 78aaa43
Copy full SHA for 78aaa43

1 file changed

+12-1Lines changed: 12 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• kaggle_requirements.txt

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎kaggle_requirements.txt‎

Copy file name to clipboardExpand all lines: kaggle_requirements.txt

+12-1Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -26,11 +26,22 @@ dipy
26	26	docker
27	27	easyocr
28	28	emoji
	29	+ # TODO: b/545164527 - unpin once fastai supports fastcore v2.
	30	+ # fastcore v2 removed L.starmap, breaking fastai's Optimizer.set_hypers:
	31	+ # https://github.com/fastai/fastai/issues/4154
	32	+ # Pinned here rather than on a direct dep because nbdev, execnb, ghapi, fastgit
	33	+ # and fastspec all pull fastcore uncapped; only constraining fastcore itself
	34	+ # makes the resolver backtrack all of them.
	35	+ fastcore<2
29	36	fasttext
30	37	featuretools
31	38	fiona
32	39	flax
33		- fury
	40	+ # TODO: b/545164527 - unpin once dipy ships its fury<2.0 cap.
	41	+ # fury 2.0 swapped VTK for pygfx/wgpu, breaking `from dipy.viz import window`.
	42	+ # dipy requires fury uncapped; fix is merged upstream but unreleased:
	43	+ # https://github.com/dipy/dipy/issues/3978
	44	+ fury<2
34	45	fuzzywuzzy
35	46	geojson
36	47	gensim

0 commit comments

Comments

0 (0)