fix: pin fury<2 and fastcore<2 to unbreak dipy and fastai tests - #1556
Merged
KeijiBranshi merged 1 commit intoAug 12, 2026
Merged
KeijiBranshi merged 1 commit into
KeijiBranshi merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
b/545164527 The scheduled build re-resolves kaggle_requirements.txt against live PyPI, so a rebuild of an unchanged commit picks up new upstream releases. Two major versions landed since the last green build and broke all four test stages: - fury 2.0.0 swapped the VTK backend for pygfx/wgpu, dropping the APIs dipy.viz needs. test_dipy fails at import. dipy/dipy#3978 - fastcore v2 removed L.starmap, called by fastai's set_hypers. test_fastai.test_tabular fails with AttributeError. fastai/fastai#4154 Both consumers declare unbounded requirements (fury>=0.12.0, fastcore>=1.14.6), so nothing stopped the resolver from crossing the major version boundary. Neither upstream has a released fix, so pin both with TODOs. fastcore is capped directly rather than via a direct dep: five packages pull it uncapped, and execnb>=2.2.5 alone forces v2, so pinning nbdev does not help. Even nbdev<3 still resolves fastcore 2.2.12. Verified by building the CPU image both ways. Before: fury 2.0.0 / fastcore 2.2.12, both tests fail with the CI tracebacks. After: fury 0.12.0 / fastcore 1.14.5 / nbdev 3.1.0, both tests pass and nbdev, execnb, ghapi and learntools still import. Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Copy Markdown
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sorry, something went wrong.
djherbis
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG=b/545164527
The scheduled build re-resolves kaggle_requirements.txt against live PyPI, so a rebuild of an unchanged commit picks up new upstream releases. Two major versions landed since the last green build and broke all four test stages:
Both consumers declare unbounded requirements (fury>=0.12.0, fastcore>=1.14.6), so nothing stopped the resolver from crossing the major version boundary. Neither upstream has a released fix, so pin both with TODOs.
fastcore is capped directly rather than via a direct dep: five packages pull it uncapped, and execnb>=2.2.5 alone forces v2, so pinning nbdev does not help. Even nbdev<3 still resolves fastcore 2.2.12.
Verified by building the CPU image both ways. Before: fury 2.0.0 / fastcore 2.2.12, both tests fail with the CI tracebacks. After: fury 0.12.0 / fastcore 1.14.5 / nbdev 3.1.0, both tests pass and nbdev, execnb, ghapi and learntools still import.
See b/545164527#comment3 for successful build