Upgrade base image to m91 - #1142
Merged
rosbo merged 3 commits intoApr 5, 2022
Merged
rosbo merged 3 commits into
rosbo merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
http://b/227193319
rosbo
commented
Apr 5, 2022
Comment thread
Dockerfile.tmpl
| RUN pip install pysal && \ | ||
| pip install seaborn python-dateutil dask python-igraph && \ | ||
| pip install pyyaml joblib husl geopy ml_metrics mne pyshp && \ | ||
| pip install pyyaml joblib husl geopy mne pyshp && \ |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Dropping ml_metrics. This is an old package created by Ben Hamner. Last updated in 2015. Fails to install at build time now:
#17 58.62 Collecting ml_metrics #17 58.64 Downloading ml_metrics-0.1.4.tar.gz (5.0 kB) #17 58.65 Preparing metadata (setup.py): started #17 59.04 Preparing metadata (setup.py): finished with status 'error' #17 59.05 error: subprocess-exited-with-error #17 59.05 #17 59.05 × python setup.py egg_info did not run successfully. #17 59.05 │ exit code: 1 #17 59.05 ╰─> [1 lines of output] #17 59.05 error in ml_metrics setup command: use_2to3 is invalid. #17 59.05 [end of output] #17 59.05 #17 59.05 note: This error originates from a subprocess, and is likely not a problem with pip. #17 59.05 error: metadata-generation-failed #17 59.05 #17 59.05 × Encountered error while generating package metadata. #17 59.05 ╰─> See above for output.
Also, it was already failing at import time.
In our Python image currently released:
import ml_metrics
Fails with:
---------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
/tmp/ipykernel_34/1657033094.py in <module>
----> 1 import ml_metrics
/opt/conda/lib/python3.7/site-packages/ml_metrics/__init__.py in <module>
----> 1 from quadratic_weighted_kappa import *
2 from elementwise import *
3 from auc import auc
4 from average_precision import apk, mapk
ModuleNotFoundError: No module named 'quadratic_weighted_kappa'
Sorry, something went wrong.
Philmod
approved these changes
Apr 5, 2022
Philmod
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM if build successful.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://b/227193319