FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix GIT_COMMIT environment variable by Philmod · Pull Request #1165 · Kaggle/docker-python · GitHub

/ docker-python Public

Fix GIT_COMMIT environment variable - #1165

Merged
Philmod merged 1 commit into
mainfrom
fix-git-commit
May 24, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Fix GIT_COMMIT environment variable#1165
Philmod merged 1 commit into
mainfrom
fix-git-commit

Conversation

Philmod commented May 24, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Philmod requested review from djherbis, jmasukawa and rosbo May 24, 2022 18:37
jmasukawa approved these changes May 24, 2022
View reviewed changes

jmasukawa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

Philmod merged commit 85f7616 into main May 24, 2022
Philmod deleted the fix-git-commit branch May 24, 2022 18:38
jmasukawa reviewed May 24, 2022
View reviewed changes
Comment thread Dockerfile.tmpl
@@ -591,7 +591,7 @@ ARG BUILD_DATE=unknown

LABEL git-commit=$GIT_COMMIT

jmasukawa May 24, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Philmod Does the fact that this may now contain brackets change how this is used at all?

Philmod May 24, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It contains brackets because the { was before the $. It shouldn't contain these brackets anymore

jmasukawa May 24, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 i just meant this other reference that also uses $GIT_COMMIT (LABEL, different than the one you changed). by it's name i imagine it's just cosmetic, but was curious.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jmasukawa jmasukawa approved these changes
rosbo rosbo approved these changes
djherbis djherbis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL