Remove CUDA_VERSION env variable and deprecated apt-key - #1486
Merged
jaesong-colab merged 3 commits intoMay 8, 2025
Merged
jaesong-colab merged 3 commits into
jaesong-colab merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jaesong-colab
marked this pull request as ready for review
May 7, 2025 22:23
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
djherbis
approved these changes
May 8, 2025
calderjo
approved these changes
May 8, 2025
calderjo
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
thanks for the clean up!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you for the review |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove setting CUDA_VERSION to empty string for CPU images. Remove getting deprecated apt-key.gpg key file from https://packages.cloud.google.com/