Fixed subtle bug where map() function was lazy and never executed, so… - #536
Merged
vimota merged 1 commit intoApr 19, 2019
Merged
vimota merged 1 commit into
vimota merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… we didn't pick up that the user had an integration connected. Also cleaned up the code to remove incorrect env var name and unused variables.
Copy link
Copy Markdown
Contributor
Author
|
test_no_project_with_connected_account() should've caught this issue but since it was passing a credentials object it wasn't hitting this condition. |
Sorry, something went wrong.
harrisse
approved these changes
Apr 18, 2019
harrisse
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
sebbov
approved these changes
Apr 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… we didn't pick up that the user had an integration connected. Also cleaned up the code to remove incorrect env var name and unused variables.