FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adds error handling messages for the user when they should be adding … by vimota · Pull Request #539 · Kaggle/docker-python · GitHub

Adds error handling messages for the user when they should be adding … - #539

Merged
Philmod merged 2 commits into
masterfrom
error_bq
Apr 25, 2019
Merged

Philmod merged 2 commits into
masterfrom
error_bq

Conversation

vimota commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

…a BQ integration

vimota requested review from harrisse and sebbov April 23, 2019 22:40

vimota commented Apr 23, 2019

Copy link
Copy Markdown
Contributor Author

This is what it will look like for the "public bq trying to access private dataset' case . I chose to use print() instead of modifiying the error message because it is more visible this way, the stack trace covers up the actual message string and you have to scroll to see it.

harrisse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Besides copy changes, LGTM!

Comment thread patches/kaggle_gcp.py Outdated
Comment thread patches/sitecustomize.py Outdated
Philmod merged commit 1f426ed into master Apr 25, 2019
Philmod deleted the error_bq branch April 25, 2019 16:59

vimota commented Apr 25, 2019

Copy link
Copy Markdown
Contributor Author

Was that merge by accident? :)

Philmod restored the error_bq branch April 25, 2019 18:23
vimota deleted the error_bq branch April 25, 2019 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL