Update google-cloud-automl to latest version and fix broken test for Catalyst - #637
Merged
mcollins42 merged 2 commits intoNov 7, 2019
Merged
mcollins42 merged 2 commits into
mcollins42 merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
djherbis
approved these changes
Nov 6, 2019
Copy link
Copy Markdown
Contributor
Author
|
I'll merge in a few hours to fix the build issue before the next automated build unless I hear otherwise. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
It's LGTM from me, go ahead whenever you like. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Thanks! I was just following my usual PR/CL etiquette of letting reviewers know that I intend to merge without waiting for responses from all in case they had comments to make. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of google-cloud-automl was pinned to 0.6.0 to resolve the issue in b/143373325. The fix for the original issue was released in google-cloud-automl 0.7.1. This change removes the pinning and goes back to the latest version of the library.
test_catalyst change: Epoch numbering changed in Catalyst 19.11 (PR: catalyst-team/catalyst#411). The master build is currently broken by this issue.