FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ensure the image to push is present on the worker by rosbo · Pull Request #785 · Kaggle/docker-python · GitHub

Ensure the image to push is present on the worker - #785

Merged
rosbo merged 1 commit into
masterfrom
fix-push
Apr 20, 2020
Merged

rosbo merged 1 commit into
masterfrom
fix-push

Conversation

rosbo commented Apr 20, 2020

Copy link
Copy Markdown
Contributor

There are no guarantees that the worker running the push step is the same than the build step.

For instance, if you have 2 workers: A & B.

A may build the image.
B may push the image.

In which case, the build fails with:

Error response from daemon: No such image: kaggle/python-gpu-build:latest

Comment thread push
docker tag "${SOURCE_IMAGE_TAG}" "${TARGET_IMAGE}:${LABEL}"
gcloud docker -- push "${TARGET_IMAGE}:${LABEL}"

# Only CPU images are made public at this time.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We stopped updating the kaggle/python repo > 1 year ago. We also don't use this script to retag the image.

rosbo requested a review from Philmod April 20, 2020 16:48
rosbo merged commit 28d87fe into master Apr 20, 2020
rosbo deleted the fix-push branch April 20, 2020 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL