FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: capture mipmap generation options in writer metadata params by walcht · Pull Request #1238 · KhronosGroup/KTX-Software · GitHub

feat: capture mipmap generation options in writer metadata params - #1238

Open
walcht wants to merge 2 commits into
KhronosGroup:mainfrom
walcht:record-mipmap-generation-params
Open

walcht wants to merge 2 commits into
KhronosGroup:mainfrom
walcht:record-mipmap-generation-params

Conversation

walcht commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

* This commit captures mipmap generation options in
  KTXWriterScParams metadata entry only if mipmap generation is
  enabled. This might help ktx2 file consumers to, for instance,
  regenerate the mipmaps using the same params.

Signed-off-by: Walid Chtioui <walid.chtioui.main@gmail.com>

walcht commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

CTS PR: KhronosGroup/KTX-Software-CTS#82

The MingW CI is failing because I pushed CTS after pushing this PR; again, I keep forgetting to push CTS first ...

Comment thread tools/ktx/command_create.cpp Outdated
Signed-off-by: Walid Chtioui <walid.chtioui.main@gmail.com>

walcht commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I suspect that the reasons you created mipmapGenerationOptionsCpy exist for these other options too.

Yes (to some degree). I enabled this for ASTC as well. For Basis Universal codecs it requires more work which is why I just ignored it.

B.t.w with regards to the OIIO reader, there are other tools used to create .ktx2 files so you cannot rely on having this information.

Yes. This is just a heuristic for a rare use case that is advised against (unless input KTX2 file is not lossy compressed which is probably very rare).

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: record mipmap generation options for ktx create/encode

2 participants


Back | FazBrowse Home | New Git URL