simplify the CMake build process for clinfo in the OpenCL SDK - #140
Draft
bashbaug wants to merge 1 commit into
Draft
bashbaug wants to merge 1 commit into
bashbaug wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hmm, there is an issue with macOS that I am going to need to resolve. Moving to "draft". |
Sorry, something went wrong.
bashbaug
marked this pull request as draft
July 24, 2025 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way we have currently integrated clinfo into the OpenCL SDK is overly complicated, involving a custom modified file that replaces one of the clinfo files. We can simplify our build process by using clinfo as-is, instead.