FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add typed modeling connection errors by pierremtb · Pull Request #1340 · KittyCAD/modeling-api · GitHub

/ modeling-api Public

Add typed modeling connection errors - #1340

Draft
pierremtb wants to merge 3 commits into
mainfrom
pierremtb/modeling-terminal-connection-errors
ConversationCommits (3)ChecksFiles changed
Draft

Add typed modeling connection errors#1340
pierremtb wants to merge 3 commits into
mainfrom
pierremtb/modeling-terminal-connection-errors

Conversation

pierremtb commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add stable modeling connection error codes for authentication, account access, concurrency limits, and backend disconnects
  • include a human-readable detail and explicit retryability in each connection error
  • expose a backward-compatible ModelingWebSocketResponse envelope while leaving the legacy WebSocketResponse unchanged
  • keep EngineParams.kcl_version represented as a string in JSON Schema so API OpenAPI generation remains compatible
  • prepare kittycad-modeling-cmds 0.2.232; 0.2.231 was already reserved when this branch was rebased

Stack

Consumed by KittyCAD/api#4472.

codecov Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.07692% with 24 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@da54cc1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/websocket.rs 63.07% 24 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1340   +/-   ##
=======================================
  Coverage        ?   36.66%           
=======================================
  Files           ?       37           
  Lines           ?     1923           
  Branches        ?        0           
=======================================
  Hits            ?      705           
  Misses          ?     1218           
  Partials        ?        0
Flag Coverage Δ
unittests 36.66% <63.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pierremtb mentioned this pull request Aug 26, 2026
Draft
pierremtb force-pushed the pierremtb/modeling-terminal-connection-errors branch from 2d5a2b2 to a20b74d Compare August 26, 2026 10:05
pierremtb marked this pull request as draft September 3, 2026 13:39
pierremtb force-pushed the pierremtb/modeling-terminal-connection-errors branch from a20b74d to d51152b Compare September 7, 2026 14:45
pierremtb mentioned this pull request Sep 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL