FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Py 2 to 3 encoding errors by vbhavank · Pull Request #410 · Kitware/SMQTK · GitHub

/ SMQTK Public

Fix Py 2 to 3 encoding errors - #410

Open
vbhavank wants to merge 2 commits into
masterfrom
Py2to3fix
ConversationCommits (2)ChecksFiles changed
Open

Fix Py 2 to 3 encoding errors#410
vbhavank wants to merge 2 commits into
masterfrom
Py2to3fix

Conversation

vbhavank commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

This merges changes made to path encodings in Caffe descriptor generator and fixed error during file upload.

vbhavank requested a review from Purg July 7, 2020 17:54

lgtm-com Bot commented Jul 7, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 13060fb into 9697837 - view on LGTM.com

new alerts:

  • 1 for Unused import

Purg reviewed Aug 11, 2020
View reviewed changes
Comment thread python/smqtk/algorithms/descriptor_generator/caffe_descriptor.py
self._log.debug("Initializing network")
self._log.debug("Loading Caffe network from network/model configs")
self.network = caffe.Net(self.network_prototxt.write_temp(),
self.network = caffe.Net(self.network_prototxt,

Purg Aug 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

self.network_prototxt here, as well as self.network_model below, should be DataElement instances at this stage. I believe Caffe 1 wanted filepaths here, thus the previous write_temp() calls. Is this not the case any more? I realize that the caffe 1 generator might be getting a little stale at this point.

vbhavank Aug 14, 2020

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It still seems to accept a string as input. I can change the documentation in Linehttps://github.com/Kitware/SMQTK/blob/654f69e0db89ce7b0a2fd13b27ef503ed4523e6b/python/smqtk/algorithms/descriptor_generator/caffe_descriptor.py#L58 to string and the setstate function to reflect the same. Please let me know if you think that sounds right.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Purg Purg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL