Fix upload progress indicator label - #1301
Merged
marySalvi merged 1 commit intoDec 20, 2022
Merged
marySalvi merged 1 commit into
marySalvi merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BryonLewis
self-requested a review
October 20, 2022 16:01
Copy link
Copy Markdown
Member
|
Hi @rgov. Sorry it took us so long to get back to you on this. I see that you closed your PR. Do you believe it's no longer relevant? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Oh I probably was just cleaning up forks and didn't realize this one had an outstanding pull request. |
Sorry, something went wrong.
marySalvi
approved these changes
Dec 20, 2022
marySalvi
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good to me
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not 100% on this change but when uploading a zip file, the progress indicator incorrectly showed "2.13 GB of 18.91 GB remaining" with the first number counting upward, not downward — the word "remaining" was not correct.