FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Customizable Time Filters by BryonLewis · Pull Request #1550 · Kitware/dive · GitHub

/ dive Public

Customizable Time Filters - #1550

Merged
BryonLewis merged 7 commits into
mainfrom
issue-1539-time-filters
Dec 1, 2025
ConversationCommits (7)ChecksFiles changed
Merged

Customizable Time Filters#1550
BryonLewis merged 7 commits into
mainfrom
issue-1539-time-filters

Conversation

BryonLewis commented Nov 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

resolves #1539

  • Quick linting for MultiCamTools.vue
  • adds timeFilter to BaseFilterControls.ts
  • implements time range filtering in TrackFilterControls.ts
  • Updates Controls.vue to include new icon and sliders for adjust the timeFilter range
  • Fixes an issue in LineChart.vue that caused multiple tooltips to display
  • Timeline.vue:
    • Refactors into <script lang='ts'> with defineComponent structure
    • Adds vertical start/end bars (green/red) for the timeline when filtering is active
    • Dims areas outside of the start/end bars
    • Enables dragging and dropping of the start/end bars.

Awaiting feedback but here is the current implementation:

DIVE-20251125-TimeFilter.mp4

BryonLewis changed the title Issue 1539 time filters Customizable Time Filters Nov 25, 2025
BryonLewis requested a review from naglepuff December 1, 2025 16:17
naglepuff previously approved these changes Dec 1, 2025
View reviewed changes

naglepuff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Had some minor comments about the refactor but the functionality works and most changes are straightforward and not controversial. As long as there are no major changes requested from users I don't mind this being merged.

Comment thread client/src/components/controls/Controls.vue Outdated
Comment thread client/src/components/controls/Timeline.vue Outdated
Comment thread client/src/components/controls/Timeline.vue Outdated
BryonLewis requested a review from naglepuff December 1, 2025 20:03
BryonLewis marked this pull request as ready for review December 1, 2025 20:24
BryonLewis merged commit f28ba7b into main Dec 1, 2025
4 checks passed
BryonLewis deleted the issue-1539-time-filters branch December 1, 2025 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

naglepuff naglepuff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adjust Track Start and End Times/Frames

2 participants

Back | FazBrowse Home | New Git URL