Fix optional annotation sidebar overlap with the toolbar - #1956
Open
mattdawkins wants to merge 1 commit into
Open
mattdawkins wants to merge 1 commit into
mattdawkins wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional right sidebar still used a hard-coded 112px toolbar offset after the annotation toolbar grew to 120px on desktop. In bottom-panel mode this placed the sidebar 8px over the toolbar; other layouts made the sidebar 8px taller than the available space.
Use Vuetify's registered top-bar offset, matching v-main, for both the sidebar position and height. Bottom-panel mode continues to reserve the panel's 260px height, so the sidebar fits between the bars. The offset also follows responsive toolbar sizing.
Validation: TypeScript checking, ESLint for SidebarContext.vue, and git diff --check passed.