FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Keep rectangle rotation math out of point and line edits by mattdawkins · Pull Request #1958 · Kitware/dive · GitHub

/ dive Public

Keep rectangle rotation math out of point and line edits - #1958

Merged
BryonLewis merged 1 commit into
mainfrom
fix/line-edit-after-point-mode
Sep 23, 2026
Merged

BryonLewis merged 1 commit into
mainfrom
fix/line-edit-after-point-mode

Conversation

Copy link
Copy Markdown
Member
  • After a point-click segmentation, dragging a head/tail endpoint threw inside the rectangle-rotation helper (unrotatedGeoJSONCoords held a Point's coordinates) before the new coordinates were emitted; the endpoint snapped back on completion.
  • Rotation bookkeeping now only runs for rectangles. Regression test covers the point-then-line sequence.

🤖 Generated with Claude Code

After a point-click session the line editor fed Point coordinates to the rotation helper, which threw before a moved endpoint was saved.
BryonLewis merged commit ec0b6e8 into main Sep 23, 2026
3 checks passed
BryonLewis deleted the fix/line-edit-after-point-mode branch September 23, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL