Clear finalized edit overlays to prevent ghost boxes and hover highlights - #1961
Merged
BryonLewis merged 1 commit intoSep 23, 2026
Merged
BryonLewis merged 1 commit into
BryonLewis merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
BryonLewis
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After right-click finalization, GeoJS can leave completed line and box annotations on an editing layer even though its mode is already disabled. The early return added in #1932 skips cleanup in that state, leaving ghost boxes on later frames and overlays that highlight on hover.
Always clear the annotations and editing state when disabling the layer. Skip only the redundant mode(null) call, preserving the companion layer’s active interactor actions.
Adds a regression test using real GeoJS right-click events followed by deselection and a frame without the detection. Validation: targeted layer tests, ESLint, and TypeScript checking.