FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Issue #73 fix alternative by Bludwarf · Pull Request #117 · Kong/unirest-java · GitHub

Issue #73 fix alternative - #117

Merged
shashiranjan84 merged 3 commits into
Kong:masterfrom
Bludwarf:master
Feb 3, 2016
Merged

Issue #73 fix alternative#117
shashiranjan84 merged 3 commits into
Kong:masterfrom
Bludwarf:master

Conversation

Copy link
Copy Markdown
Contributor

Header name case sensitive

…rst(key)"

This reverts commit 4412a01.

Conflicts:
	src/main/java/com/mashape/unirest/http/Headers.java
	src/test/java/com/mashape/unirest/test/http/HeadersTest.java
Change test location
shashiranjan84 added a commit that referenced this pull request Feb 3, 2016
shashiranjan84 merged commit 46f50eb into Kong:master Feb 3, 2016

MinnDevelopment commented Nov 19, 2016
edited
Loading

Copy link
Copy Markdown

HTTP Header names are not case sensitive by any means, this is not a fix as this breaks headers.
It does not matter what case a header name is since these can be changed by any proxy/server.
I request this to be reverted.

Section 4.2 from https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html says:
Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.

ducc commented Jun 5, 2017
edited
Loading

Copy link
Copy Markdown

Bump. What @MinnDevelopment said is correct and case sensitive headers are a pain in the ass.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL