Test leap years - #272
Open
pnemonic78 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
KosherJava
reviewed
May 18, 2026
Comment thread
src/main/java/com/kosherjava/zmanim/hebrewcalendar/JewishDate.java
Outdated
| return true; | ||
| } | ||
| if (object == null || getClass() != object.getClass()) { | ||
| if (!(object instanceof JewishDate)) { |
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
@pnemonic78 , I believe that this change will treat a JewishDate and JewishCalendar as equals, something that should probably not be the case. Other than this I committed the rest of the changes in JewishDate in dfcb12d
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding issue #121