Fix WIM filesystem - #3
Merged
Olof-Lagerkvist merged 4 commits intoJan 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
6 tasks
Copy link
Copy Markdown
Author
|
Thanks for merging. Could you please push the new package version to nuget? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Yes, they should be available there in a few minutes! Thanks again! |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Thank you, and thanks for your great work with DiscUtils ⭐ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a bug that affects the WIM file system where no entries are returned for root directories.
This is a result of the change introduced by the switch to the LTRData.SplitExtensions split function, see: f09f015#diff-ab45e438d7f2403bff5c28a276f345a016c816c8ef1893d3fb7c29858901891cR716
This function doesn't return anything when there are no results for Split, in contrast to the .NET Split which always returns the original search string (with the default split options).
The result of this change is that everything in GetEntry is skipped over since path.Length == 0 if there were no matches.
I have opened a PR to fix this in your other repo: LTRData/Library#1
This PR takes the updated version of LTRData.SplitExtensions and adds a simple regression test for WIM filesystems.