FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: support arrow-directions in plantuml by Chaaph · Pull Request #34 · LukasNiessen/ArchUnitPython · GitHub

feat: support arrow-directions in plantuml - #34

Open
Chaaph wants to merge 1 commit into
LukasNiessen:mainfrom
Chaaph:uml/support-directional-arrows
Open

feat: support arrow-directions in plantuml#34
Chaaph wants to merge 1 commit into
LukasNiessen:mainfrom
Chaaph:uml/support-directional-arrows

Conversation

Chaaph commented Jul 15, 2026
edited
Loading

Copy link
Copy Markdown

Pull Request

Slice-level architecture rules: PlantUML diagram validation now also works with directional arrows.

Change Type

  • Bug fix
  • Feature
  • Documentation
  • Refactoring

Chaaph requested a review from LukasNiessen as a code owner July 15, 2026 09:27

Copy link
Copy Markdown
Collaborator

Requesting one parser change before merge: the new re.sub runs across the entire line and accepts any lowercase word. That means a relationship such as [api-d->handler] -> [db] is rewritten with a different source name, while an unsupported token such as -banana-> is accepted as an arrow direction.

Please match/normalize the direction only within the relationship operator and restrict it to the intended PlantUML direction aliases. Please also assert the generated rule's source and target and add coverage for an endpoint containing direction-shaped text and for an unsupported token. The existing -d-> happy-path test is a useful starting point.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL