Add suite of flux-corrected transport tests for landice integration - #650
Add suite of flux-corrected transport tests for landice integration#650trhille wants to merge 9 commits into
Conversation
Sorry, something went wrong.
| landice/dome/variable_resolution/fo_fct_restart_test | ||
| landice/greenland/fo_fct_decomposition_test | ||
| landice/greenland/fo_fct_restart_test | ||
| landice/thwaites/fct_decomposition_test |
There was a problem hiding this comment.
I'm wondering if we ought to revamp the naming conventions to make it clear when 'fo' or other abbreviations refer to velocity solve vs advection vs other possible settings. I imagine compass list is getting pretty busy.
Sorry, something went wrong.
There was a problem hiding this comment.
Agreed.
Sorry, something went wrong.
There was a problem hiding this comment.
Also, making a note that we'll need to change the names of the tests in the full_integration suite (and docs) accordingly (discovered this trying to run full_integration from this branch).
Sorry, something went wrong.
Add new fct advection tests for dome group
The namelist files in the run step were not being properly updated to ust fct advection. This fixes that.
Add 3km fct full physics tests for humboldt. Note that the decomposition tests do not pass validation, but testing shows that they also fail using fo advection.
Add fct_integration suite, which uses a subset of the new fct advection tests based on the tests in full_integration.
Fix names of thwaites tests in suite definition file. Note that the
naming convention of these tests is currently {advection}_{velocity_solver},
which is the reverse of the convention for other tests. This will be
addressed in a future commit.
Use RK2 time integration with all tests in fct_integration suite.
Reviewers
At least 1 approving review is required to merge this pull request.
Add suite of landice integration tests using flux-corrected transport that is currently being implemented in MALI-Dev/E3SM#70.
Checklist