Implement SSPI authentication - #1128
Merged
elprans merged 2 commits intoMar 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
eltoder
force-pushed
the
feature/sspi-auth
branch
2 times, most recently
from
c0219f1 to
72a5fda
Compare
March 5, 2024 17:08
elprans
reviewed
Mar 5, 2024
Comment thread
tests/test_connect.py
|
|
||
| if _system == 'Windows': | ||
| DEFAULT_GSSLIB = 'sspi' | ||
| OTHER_GSSLIB = 'gssapi' |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Since this makes it possible to use gssapi on Windows also, should the gssapi dependency be made unconditional of platform_system?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Good question. My idea here was to only install the default library which is the most likely to work. Using gssapi on Windows requires installing Kerberos for Windows, so it probably needs manual steps anyway. We can install gssapi and let the user deal with the error for missing KfW, or we can document this better somewhere. Happy to do either way.
Technically, sspilib can be used on non-Windows as well, so we can install both unconditionally, but this is even more experimental and exotic.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
In any case, we should update the installation page: https://magicstack.github.io/asyncpg/current/installation.html
Sorry, something went wrong.
SSPI is a Windows technology for secure authentication. SSPI and GSSAPI interoperate as clients and servers. Postgres documentation recommends using SSPI on Windows clients and servers and GSSAPI on non-Windows platforms[1]. Changes in this PR: * Support AUTH_REQUIRED_SSPI server request. This is the same as AUTH_REQUIRED_GSS, except it allows negotiation with SSPI clients. * Allow using SSPI on the client. Which library to use can be specified using the `gsslib` connection parameter. * Use SSPI instead of GSSAPI on Windows by default. The latter requires installing Kerberos for Windows and is unlikely to work out of the box. Closes MagicStack#142 [1] https://www.postgresql.org/docs/current/sspi-auth.html
eltoder
force-pushed
the
feature/sspi-auth
branch
from
72a5fda to
69375b1
Compare
March 6, 2024 14:49
Copy link
Copy Markdown
Contributor
Author
|
@elprans I updated documentation and renamed the extra to hopefully make it more clear. Please take another look. |
Sorry, something went wrong.
eltoder
force-pushed
the
feature/sspi-auth
branch
from
ae9023b to
3ced615
Compare
March 9, 2024 17:29
elprans
approved these changes
Mar 11, 2024
elprans
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. Thanks for contributing!
Sorry, something went wrong.
bryanforbes
added a commit
to bryanforbes/asyncpg-stubs
that referenced
this pull request
Mar 11, 2024
Copy link
Copy Markdown
Contributor
Author
|
@elprans when are you planning to make the next release? |
Sorry, something went wrong.
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
Merged
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
Merged
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSPI is a Windows technology for secure authentication. SSPI and GSSAPI interoperate as clients and servers. Postgres documentation recommends using SSPI on Windows clients and servers and GSSAPI on non-Windows platforms[1].
Changes in this PR:
Support AUTH_REQUIRED_SSPI server request. This is the same as AUTH_REQUIRED_GSS, except it allows negotiation with SSPI clients.
Allow using SSPI on the client. Which library to use can be specified using the gsslib connection parameter.
Use SSPI instead of GSSAPI on Windows by default. The latter requires installing Kerberos for Windows and is unlikely to work out of the box.
Closes #142
[1] https://www.postgresql.org/docs/current/sspi-auth.html