Add typing to auxiliary classes around Pool - #1197
Merged
elprans merged 2 commits intoNov 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Removed the stringified annotations based on the review in #1198 as that seems to be the preferred style. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@elprans Anything I can do to help get this merged? I don't want to spam you with pull requests but these are relatively trivial to make and there is still many more to make as well. I'd like to find the most productive way to get these and other pull requests merged. For example, is there anybody else in the MagicStack team that can help review and merge these? |
Sorry, something went wrong.
elprans
approved these changes
Nov 4, 2024
elprans
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM! Thanks, @DanielNoord
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to add more type annotations to common interfaces I decided to tackle some of the simpler methods. Also, to familiarise myself with the CI and project.
There is nothing groundbreaking in this PR. It:
Let me know if there are any questions. I didn't really see any style checking recommendations in the documentation or setup.py so just used what black, ruff and others have decided is the de facto style of "modern" Python code.