Add Pool.on_acquire hook with AcquireEvent - #1320
Open
janbjorge wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Adds an optional `on_acquire` callback to `Pool` / `create_pool`, mirroring the existing setup/init/reset style. The callback is invoked synchronously with an `AcquireEvent(wait_seconds, size, idle, max_size)` after every successful `Pool.acquire` dispatch. Lets applications detect pool saturation (long wait, idle == 0) without subclassing the pool or wrapping every callsite. Callback exceptions are logged and suppressed. No behavior change when unused.
Caller branches in `_acquire` so `_fire_on_acquire` does not need a redundant None check.
janbjorge
marked this pull request as ready for review
May 14, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional on_acquire callback to Pool / create_pool, mirroring the existing setup/init/reset style. The callback is invoked synchronously with an AcquireEvent(wait_seconds, size, idle, max_size) after every successful Pool.acquire dispatch. Lets applications detect pool saturation (long wait, idle == 0) without subclassing the pool or wrapping every callsite. Callback exceptions are logged and suppressed. No behavior change when unused.