Loosen message test in test_invalid_input - #751
Merged
elprans merged 2 commits intoApr 26, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… as an integer)” wherever we expected “an integer is required”; required for Python 3.10 compatibility
musicinmybrain
force-pushed
the
test_invalid_input-python3.10
branch
from
e5a9138 to
6cd74b1
Compare
April 26, 2021 12:01
elprans
reviewed
Apr 26, 2021
Comment thread
tests/test_codecs.py
Outdated
…ing literal. Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
elprans
approved these changes
Apr 26, 2021
elprans
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test_invalid_input, also accept “(str object cannot be interpreted as an integer)” wherever we expected “an integer is required”; required for Python 3.10 compatibility. This fixes #750.