FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't stop the loop in `run_until_complete()` on `SystemExit` and `KeyboardInterrupt` exceptions by Jackenmen · Pull Request #337 · MagicStack/uvloop · GitHub

Repository navigation

Don't stop the loop in run_until_complete() on SystemExit and KeyboardInterrupt exceptions - #337

Merged
fantix merged 3 commits into
MagicStack:masterfrom
Jackenmen:patch-1
Feb 8, 2021
Merged

fantix merged 3 commits into
MagicStack:masterfrom
Jackenmen:patch-1

Conversation

Copy link
Copy Markdown
Contributor

Fixes #336

1st1 commented May 13, 2020

Copy link
Copy Markdown
Member

Can you add a unittest?

Copy link
Copy Markdown
Contributor Author

@1st1 I added the unit test based on CPython's equivalent and rebased the PR's branch on top of master.
Let me know if there's anything else you would want me to do.

Jackenmen commented Feb 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've rebased this on top of master since it looks like there's a new required check (although now I see it doesn't seem to work?) + it's been moved to the project board it seems. I'm still available to do any additional changes if needed so just let me know if needed.

I'm also mentioning this since I'm hoping this could get included in the next release, whenever it's ready of course :)

fantix commented Feb 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for the PR! The thing is the test is NOT failing without the fix, I'm looking into it now.

UPDATE: Looks like this cpython test was added before _StopError was removed. Because current asyncio will complete running the whole _ready queue before actually stopping the loop, the func() is always called. So we should fix the test both here and in asyncio.

fantix merged commit 8c471f8 into MagicStack:master Feb 8, 2021
This was referenced Feb 10, 2021
Jackenmen deleted the patch-1 branch February 11, 2021 21:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loop.run_until_complete raises RuntimeError after catching SystemExit

3 participants


Back | FazBrowse Home | New Git URL