| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Can you add a unittest? |
Sorry, something went wrong.
|
@1st1 I added the unit test based on CPython's equivalent and rebased the PR's branch on top of master. |
Sorry, something went wrong.
|
I've rebased this on top of master since it looks like there's a new required check (although now I see it doesn't seem to work?) + it's been moved to the project board it seems. I'm still available to do any additional changes if needed so just let me know if needed. I'm also mentioning this since I'm hoping this could get included in the next release, whenever it's ready of course :) |
Sorry, something went wrong.
|
Thanks for the PR! The thing is the test is NOT failing without the fix, I'm looking into it now. UPDATE: Looks like this cpython test was added before _StopError was removed. Because current asyncio will complete running the whole _ready queue before actually stopping the loop, the func() is always called. So we should fix the test both here and in asyncio. |
Sorry, something went wrong.
Co-authored-by: Victor Stinner <victor.stinner@gmail.com>
| Back | FazBrowse Home | New Git URL |
Fixes #336