Repository navigation
Fix build for Python 3.14 - #638
fantix merged 12 commits into
Conversation
Sorry, something went wrong.
In extreme cases, isinstance(..., ()) may still return False instead of raising a TypeError
This uses private API now. Proper fix pending discussion in python/cpython#131148
* Add deprecation in docstring * Stop using private API, refs python/cpython#131148 * Use AbstractEventLoop instead, after @Vizonex's suggestion
There was a problem hiding this comment.
@graingert @fantix
I like the fact that my approach from winloop is being utilized here but would it be smart if the install() function threw an error if 3.16+ is used?
Sorry, something went wrong.
|
I'm not sure, but I feel like it's fine that uvloop.install raises AttributeError on Python 3.16 after versions of deprecation, maybe with a proper error message. Let me add that! |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good. I'll have to mirror some of this myself even though I don't agree with all of it but it works nevertheless. You'll have to let 1st1 review it since I'm not the deciding factor but wanted to provide input and feedback to the project since I run the windows version of it.
Sorry, something went wrong.
| cdef aio_set_running_loop = getattr(asyncio, '_set_running_loop', None) | ||
| cdef aio_debug_wrapper = getattr(asyncio.coroutines, 'debug_wrapper', None) | ||
| cdef aio_AbstractChildWatcher = asyncio.AbstractChildWatcher | ||
| cdef aio_AbstractChildWatcher = getattr(asyncio, "AbstractChildWatcher", ()) |
There was a problem hiding this comment.
Why () and not just None?
Sorry, something went wrong.
There was a problem hiding this comment.
() is a type, but None is not. We have usages like isinstance(..., aio_AbstractChildWatcher) and () returns False instead of TypeError.
Sorry, something went wrong.
There was a problem hiding this comment.
() is shorthand for tuple()
Much like {} is shorthand for dict()
Sorry, something went wrong.
| from ._version import __version__ # NOQA | ||
|
|
||
|
|
||
| __all__ = ('new_event_loop', 'install', 'EventLoopPolicy') |
There was a problem hiding this comment.
is _typing.Tuple[str, ...] necessary here?
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah the later __all__ += (...) would break typing
Sorry, something went wrong.
1st1
left a comment
There was a problem hiding this comment.
Good stuff, i've only two nit comments
Sorry, something went wrong.
Changes ======= * Fixes for Python 3.14 (#638) (by @graingert @hroncok @paulocheque @fantix in 46456b6 for #637) Fixes ===== * Use Cython `enum` for `__PREALLOCED_BUFS` (#634) (by @jakirkham in 7bb12a1 for #634) * test: fix getaddrinfo test (#663) (by @fantix in 5680792 for #663) * test: fix task name for Python 3.13.3/3.14 (#662) (by @cjwatson in 96b7ed3 for #662)
|
It seems that the 3.14 tests are still failing on main, any idea what happened there? Or was the intention to just fix the build? |
Sorry, something went wrong.
Changes ======= * Fixes for Python 3.14 (#638) (by @graingert @hroncok @paulocheque @fantix in 46456b6 for #637) * Add free-threading support (#693) (by @kumaraditya303 in 286b370 for #642) Fixes ===== * Use Cython `enum` for `__PREALLOCED_BUFS` (#634) (by @jakirkham in 7bb12a1 for #634) * test: fix getaddrinfo test (#663) (by @fantix in 5680792 for #663) * test: fix task name for Python 3.13.3/3.14 (#662) (by @cjwatson in 96b7ed3 for #662)
Changes ======= * Fixes for Python 3.14 (#638) (by @graingert @hroncok @paulocheque @fantix in 46456b6 for #637) * Add free-threading support (#693) (by @kumaraditya303 in 286b370 for #642) Fixes ===== * Use Cython `enum` for `__PREALLOCED_BUFS` (#634) (by @jakirkham in 7bb12a1 for #634) * test: fix getaddrinfo test (#663) (by @fantix in 5680792 for #663) * test: fix task name for Python 3.13.3/3.14 (#662) (by @cjwatson in 96b7ed3 for #662)
Changes ======= * Fixes for Python 3.14 (#638) (by @graingert @hroncok @paulocheque @fantix in 46456b6 for #637) * Add free-threading support (#693) (by @kumaraditya303 in 286b370 for #642) Fixes ===== * Use Cython `enum` for `__PREALLOCED_BUFS` (#634) (by @jakirkham in 7bb12a1 for #634) * test: fix getaddrinfo test (#663) (by @fantix in 5680792 d9fa054 for #663) * test: fix task name for Python 3.13.3/3.14 (#662) (by @cjwatson in 96b7ed3 for #662)
Changes ======= * Fixes for Python 3.14 (#638) (by @graingert @hroncok @paulocheque @fantix in 46456b6 for #637) * Add free-threading support (#693) (by @kumaraditya303 in 286b370 for #642) Fixes ===== * Use Cython `enum` for `__PREALLOCED_BUFS` (#634) (by @jakirkham in 7bb12a1 for #634) * test: fix getaddrinfo test (#663) (by @fantix in 5680792 d9fa054 for #663) * test: fix task name for Python 3.13.3/3.14 (#662) (by @cjwatson in 96b7ed3 for #662)
Fixes #637