| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Should've checked other PRs and issues. Apologies.
Upon reviewing, they're both missing some important areas that needed to be addressed (e.g. build-system.requires) for merging. This PR also doesn't convert Cython.__version__ to Version(Cython.__version__) as it's not needed. Lastly, it bounds the packaging version to >=20 which contains the minimal API's needed for what its used for (verified manually). Note, the CI failures on 3.13.12 (less prominent on 3.13.11) and 3.14.3 (less prominent on 3.14.2) pipelines on test_create_ssl_server_manual_connection_lost when PYTHONASYNCIODEBUG=1 is set is unrelated to this change and seem to be happening in all other open PR's. These unrelated failures would be fixed by #743 |
Sorry, something went wrong.
|
There's generally no point in using packaging to check for cython version. If the user has the correct packaging installed they probably are building using PEP 517 already so the check is redundant personally I'd just remove this code |
Sorry, something went wrong.
Fair, I agree as well 😅. I kept it as-is as that's what pkg_resources was being used for before. Trying to make it as simple as possible for the reviewers... |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
When trying to build uvloop locally, I ended up encountering the issues mentioned in pypa/setuptools#5174
Reliance of pkg_resources causes pip install -e . to break given setuptools>60 build requirement pulls setuptools 82+. While a plausible fix is to setup a constraint like ,<82, I thought it'd be better to move to use packaging given the purpose pkg_resources was being used for (version checking) to avoid constraining downstream builders.
I also made sure the Cython versions were aligned to ~=3.1, seems like misalignment was introduced after #693
Disclosure (because this seems needed nowadays): This PR is made by human-only contribution without AI usage.
Closes #729