handle check when using TINYOWS_MAPFILE - #97
Merged
jmckenna merged 6 commits intoJun 18, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
sebastic
reviewed
Jun 12, 2021
Comment thread
src/mapfile/mapfile.l
Outdated
sebastic
reviewed
Jun 12, 2021
Comment thread
src/mapfile/mapfile.l
Outdated
tigerfoot
reviewed
Jun 21, 2021
Comment thread
Makefile.in
|
|
||
| all: | ||
| $(CC) -o tinyows $(SRC) $(XMLFLAGS) $(CFLAGS) $(PGFLAGS) $(FCGIFLAGS) $(GIT_FLAGS) -lfl | ||
| $(CC) $(CFLAGS) $(POSTGIS_INC) $(XML2_INC) $(FCGI_INC) $(SVN_FLAGS) $(SRC) -o tinyows -lfl $(POSTGIS_LIB) $(XML2_LIB) $(FCGI_LIB) |
Copy link
Copy Markdown
There was a problem hiding this comment.
There's no reference in code to SVN_FLAGS and we loose GIT_FLAGS (obsolete Debian patch)
Also if PGFLAGS (which concat POSTGIS_INC an dPOSTGIS_LIBS) it should be removed everywhere.
same should be done for XMLFLAGS FCGIFLAGS ?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
@tigerfoot can you create a pull request with these changes?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes tests here on Windows. More testing welcomed! (cc @sebastic )