SS-504 - kafka sink: add sink id header to published messages. - #39566
Merged
martykulma merged 1 commit intoOct 6, 2026
Merged
martykulma merged 1 commit into
martykulma merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
If the feature flag is enabled, unconditionally adds a `materialize-sink-id` header to published messages.
martykulma
marked this pull request as ready for review
October 5, 2026 22:37
peterdukelarsen
approved these changes
Oct 6, 2026
peterdukelarsen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
thanks for the review! |
Sorry, something went wrong.
val-materialize
added a commit
that referenced
this pull request
Oct 6, 2026
…iew) (#39590) Part of [SS-504](https://linear.app/materializeinc/issue/SS-504). Follow-up to #39566, which added the header behind the `kafka_sink_emit_sink_id_header` flag. Docs only. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the feature flag is enabled, unconditionally adds a materialize-sink-id header to published messages. The materialize- prefix is reserved. The existing behavior is to drop any user supplied values (i.e. they aren't added to the message). The flag only takes effect on sink startup, which follows the behavior of existing flags.
Adds mzcompose tests to cover publishing with and without the feature enabled.