FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix build warning and Windows build break by AArnott · Pull Request #2300 · MessagePack-CSharp/MessagePack-CSharp · GitHub

/ MessagePack-CSharp Public

Fix build warning and Windows build break - #2300

Merged
AArnott merged 2 commits into
masterfrom
fix/windows-build-validation
Sep 17, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Fix build warning and Windows build break#2300
AArnott merged 2 commits into
masterfrom
fix/windows-build-validation

Conversation

AArnott commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes build break on Windows machines since .NET Framework targeting is only included on Windows.
  • Patch the PR check hole that allowed the Windows build break to slip through.
  • Remove the test file WRITE_EXPECTED C# define that is never supposed to be committed and was generating a build warning.
  • Patch the PR check hole that allowed the compiler warning to slip through.

Validation

  • dotnet build -t:Rebuild
  • dotnet build -c Release -t:build,pack
  • dotnet test -c Release --no-build

AArnott and others added 2 commits September 17, 2026 09:58
Validate Windows builds
912ced7 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Treat CI build warnings as errors
f7a4852 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AArnott requested a review from neuecc September 17, 2026 16:05
AArnott changed the title Validate Windows builds Fix build warning and Windows build break Sep 17, 2026
AArnott merged commit ab3119e into master Sep 17, 2026
4 checks passed
AArnott deleted the fix/windows-build-validation branch September 17, 2026 16:12
This was referenced Sep 17, 2026
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Open
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
This was referenced Sep 28, 2026
Open
Open
Open
Open
Closed
Closed
Open
Closed
Open
Closed
Open
Open
Merged
Open
Open
Open
Open
Merged
Closed
Open
Open
Open
Closed
Closed
Open
Open
Open
Closed
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

neuecc Awaiting requested review from neuecc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL